chia7712 commented on code in PR #21096:
URL: https://github.com/apache/kafka/pull/21096#discussion_r2630350347
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java:
##########
@@ -55,11 +55,11 @@ public ProducerStateEntry(long producerId, short
producerEpoch, int coordinatorE
firstBatchMetadata.ifPresent(batchMetadata::add);
Review Comment:
If we have to handle the "first" batch in constructor, I would prefer to
adopt @jolshan auggestion.
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java:
##########
@@ -55,11 +55,11 @@ public ProducerStateEntry(long producerId, short
producerEpoch, int coordinatorE
firstBatchMetadata.ifPresent(batchMetadata::add);
Review Comment:
If we have to handle the "first" batch in constructor, I would prefer to
adopt @jolshan suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
