adixitconfluent opened a new pull request, #21236: URL: https://github.com/apache/kafka/pull/21236
### About This PR performs cleanup in `SharePartition.java` acknowledgement flow. We do not need `Objects.requireNonNull(recordState);` firstly because this has been covered in this [code](https://github.com/apache/kafka/blob/trunk/core/src/main/java/kafka/server/share/SharePartition.java#L1000). Also throwing a `NullPointerException` is indeed wrong for an invalid acknowledge type provided by the client. ### Testing Added some unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
