apoorvmittal10 commented on code in PR #21236:
URL: https://github.com/apache/kafka/pull/21236#discussion_r2657713207
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -2387,7 +2386,6 @@ private Optional<Throwable> acknowledgeCompleteBatch(
// either released or moved to a state where member id existence
is not important. The member id
// is only important when the batch is acquired.
RecordState recordState = ACK_TYPE_TO_RECORD_STATE.get(ackType);
- Objects.requireNonNull(recordState);
Review Comment:
Anything is fine but some exception whould highlight the map is missing the
required value.
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -2387,7 +2386,6 @@ private Optional<Throwable> acknowledgeCompleteBatch(
// either released or moved to a state where member id existence
is not important. The member id
// is only important when the batch is acquired.
RecordState recordState = ACK_TYPE_TO_RECORD_STATE.get(ackType);
- Objects.requireNonNull(recordState);
Review Comment:
Anything is fine but some exception should highlight the map is missing the
required value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
