jiafu1115 commented on code in PR #20938:
URL: https://github.com/apache/kafka/pull/20938#discussion_r2657861535
##########
server/src/test/java/org/apache/kafka/server/BootstrapControllersIntegrationTest.java:
##########
@@ -226,27 +226,29 @@ public void testIncrementalAlterConfigs(ClusterInstance
clusterInstance) throws
}
private void testIncrementalAlterConfigs(ClusterInstance clusterInstance,
boolean usingBootstrapControllers) throws Exception {
+ Collection<Integer> nodeIds = usingBootstrapControllers ?
+ clusterInstance.controllerIds() :
+
List.of(clusterInstance.brokers().values().iterator().next().config().nodeId());
try (Admin admin = Admin.create(adminConfig(clusterInstance,
usingBootstrapControllers))) {
- int nodeId = usingBootstrapControllers ?
-
clusterInstance.controllers().values().iterator().next().config().nodeId() :
-
clusterInstance.brokers().values().iterator().next().config().nodeId();
- ConfigResource nodeResource = new ConfigResource(BROKER, "" +
nodeId);
- ConfigResource defaultResource = new ConfigResource(BROKER, "");
- Map<ConfigResource, Collection<AlterConfigOp>> alterations =
Map.of(
- nodeResource, List.of(new AlterConfigOp(new
ConfigEntry("my.custom.config", "foo"), AlterConfigOp.OpType.SET)),
- defaultResource, List.of(new AlterConfigOp(new
ConfigEntry("my.custom.config", "bar"), AlterConfigOp.OpType.SET))
- );
- admin.incrementalAlterConfigs(alterations).all().get(1,
TimeUnit.MINUTES);
- TestUtils.retryOnExceptionWithTimeout(30_000, () -> {
- Config config = admin.describeConfigs(List.of(nodeResource)).
- all().get(1, TimeUnit.MINUTES).get(nodeResource);
- ConfigEntry entry = config.entries().stream().
- filter(e -> e.name().equals("my.custom.config")).
- findFirst().orElseThrow();
- assertEquals(DYNAMIC_BROKER_CONFIG, entry.source(),
- "Expected entry for my.custom.config to come from
DYNAMIC_BROKER_CONFIG. " +
- "Instead, the entry was: " + entry);
- });
+ for (int nodeId : nodeIds) {
+ ConfigResource nodeResource = new ConfigResource(BROKER, "" +
nodeId);
+ ConfigResource defaultResource = new ConfigResource(BROKER,
"");
+ Map<ConfigResource, Collection<AlterConfigOp>> alterations =
Map.of(
+ nodeResource, List.of(new AlterConfigOp(new
ConfigEntry("my.custom.config", "foo"), AlterConfigOp.OpType.SET)),
+ defaultResource, List.of(new AlterConfigOp(new
ConfigEntry("my.custom.config", "bar"), AlterConfigOp.OpType.SET))
Review Comment:
@chia7712 Done. I add two configure items for test instead of only one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
