dajac commented on PR #21263: URL: https://github.com/apache/kafka/pull/21263#issuecomment-3719487766
> Not introduced in this PR but I'm not too happy about the `onMetadataUpdate` being the only method that throws `ExecutionException` and `InteruptedException` in the interface. Based on https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/Future.html#get--, `ExecutionException` should never happen since we catch exceptions coming from the futures and maybe we could swallow `InterruptedException` and convert it to `Thread.currentThread().interrupt()`? Interesting... An alternative would be to use `join()`. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
