dongnuo123 commented on code in PR #21263:
URL: https://github.com/apache/kafka/pull/21263#discussion_r2669199110
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##########
@@ -186,22 +184,6 @@ class BrokerMetadataPublisher(
case t: Throwable =>
metadataPublishingFaultHandler.handleFault("Error updating share " +
s"coordinator with local changes in $deltaName", t)
}
- try {
- // Notify the group coordinator about deleted topics.
- val deletedTopicPartitions = new
mutable.ArrayBuffer[TopicPartition]()
- topicsDelta.deletedTopicIds().forEach { id =>
- val topicImage = topicsDelta.image().getTopic(id)
- topicImage.partitions().keySet().forEach {
- id => deletedTopicPartitions += new
TopicPartition(topicImage.name(), id)
- }
- }
- if (deletedTopicPartitions.nonEmpty) {
-
groupCoordinator.onPartitionsDeleted(deletedTopicPartitions.asJava,
RequestLocal.noCaching.bufferSupplier)
- }
- } catch {
- case t: Throwable =>
metadataPublishingFaultHandler.handleFault("Error updating group " +
- s"coordinator with deleted partitions in $deltaName", t)
Review Comment:
This seems to be replaced by the general `with local changes` but I guess
it's fine as we also log error message in futures exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
