kevin-wu24 commented on code in PR #20707: URL: https://github.com/apache/kafka/pull/20707#discussion_r2670651896
########## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/TestBootstrapDirectory.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.metadata.bootstrap; + +import java.io.FileNotFoundException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Objects; + +import static org.apache.kafka.common.internals.Topic.CLUSTER_METADATA_TOPIC_PARTITION; + +/** + * Test-only implementation that reads bootstrap metadata from the metadata partition snapshot. + */ +public class TestBootstrapDirectory implements BootstrapDirectory { Review Comment: There is one difference, in that the `LegacyBootstrapDirectory#read()` (which reads `bootstrap.checkpoint`, will default to the `readFromConfiguration()` so that the returned `BootstrapMetadata` object is never null. I felt that `TestBootstrapDirectory` should not have a similar behavior as above. The main reason we need that functionality is to verify the contents of the `0-0.checkpoint` file within unit test files. ########## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/TestBootstrapDirectory.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.metadata.bootstrap; + +import java.io.FileNotFoundException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Objects; + +import static org.apache.kafka.common.internals.Topic.CLUSTER_METADATA_TOPIC_PARTITION; + +/** + * Test-only implementation that reads bootstrap metadata from the metadata partition snapshot. + */ +public class TestBootstrapDirectory implements BootstrapDirectory { Review Comment: There is one difference, in that the `LegacyBootstrapDirectory#read()` (which reads `bootstrap.checkpoint`), will default to the `readFromConfiguration()` so that the returned `BootstrapMetadata` object is never null. I felt that `TestBootstrapDirectory` should not have a similar behavior as above. The main reason we need that functionality is to verify the contents of the `0-0.checkpoint` file within unit test files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
