kevin-wu24 commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r2670662776
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -123,6 +123,7 @@ object StorageTool extends Logging {
val formatter = new Formatter().
setPrintStream(printStream).
setNodeId(config.nodeId).
+
setWriteBootstrapSnapshot(config.processRoles.contains(ProcessRole.ControllerRole)).
Review Comment:
I think we realized this behavior makes more sense after starting the
implementation. Pre-KIP-1170 during formatting, brokers would also write
`bootstrap.checkpoint` (which is not used since broker-only processes cannot
write this data to the metadata log), but only KIP-853 bootstrap controllers
would write `0-0.checkpoint`.
Now that we are moving towards only a `0-0.checkpoint` with both metadata
and control records, I don't think it makes sense to have brokers write the
`0-0.checkpoint`. Only controllers should write this file to disk when
formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
