mjsax commented on code in PR #21269:
URL: https://github.com/apache/kafka/pull/21269#discussion_r2673325696
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##########
@@ -4086,13 +4086,11 @@ private List<Integer> topicPartitionLeader(Admin
adminClient, String topicName,
}
private SharePartitionOffsetInfo sharePartitionOffsetInfo(Admin
adminClient, String groupId, TopicPartition tp) throws InterruptedException,
ExecutionException {
- SharePartitionOffsetInfo partitionResult;
ListShareGroupOffsetsResult result = adminClient.listShareGroupOffsets(
Map.of(groupId, new
ListShareGroupOffsetsSpec().topicPartitions(List.of(tp))),
new ListShareGroupOffsetsOptions().timeoutMs(30000)
);
- partitionResult = result.partitionsToOffsetInfo(groupId).get().get(tp);
- return partitionResult;
+ return result.partitionsToOffsetInfo(groupId).get().get(tp);
Review Comment:
These rewrites (for the whole PR) are ok, but also do not really add much
value...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
