Pankraz76 commented on PR #21269: URL: https://github.com/apache/kafka/pull/21269#issuecomment-3729007579
> If the proposal is to *replace* checkstyle and spotbugs with openrewrite, we should discuss that. No, that's not my intent. All the tools have their individual benefit. Even on one and the same issue like this, having a layered stack of Checkstyle, Spotless, SpotBugs, PMD, and Error Prone, Rewrite still finds some methods that all other tools don't. (That's actually the Checkstyle stack, so this is a real-world example.) So it's about having redundancy in critical infrastructure. Also, each tool has its dedicated features, like Java migration as an example: * https://github.com/checkstyle/checkstyle/issues/18531 It's not about talking good or bad about any other tool. It's just about getting the job done on the unused method stuff, then considering that—beyond recipes—each offers individual benefit again. So the discussion should be simple in this regard, as it's "only" a new tool solving an already applied convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
