0xffff-zhiyan commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2683235550
##########
metadata/src/main/java/org/apache/kafka/image/ConfigurationDelta.java:
##########
@@ -56,19 +70,28 @@ public void deleteAll() {
}
public ConfigurationImage apply() {
+ Set<String> whitelist = VALID_CONFIGS_REF.get();
Review Comment:
> Should we instead commit an explicit "delete these X unknown dynamic
config records" to KRaft alongside the user's requested alter config upon
receiving an alter config request that would otherwise be invalid because of
unknown configs?
So does that mean we only clean up invalid configs when handling alter
config records?
I think maybe it’s acceptable to do cleanup in both listeners, even if that
results in some duplicate logic. For the alter config failure scenario, in my
current PR before validating existing configs, I simply filter out invalid ones
so that validation can proceed. This is only to prevent validation failures,
not to clean up the underlying config state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
