0xffff-zhiyan commented on PR #21053: URL: https://github.com/apache/kafka/pull/21053#issuecomment-3751744135
> @andrewgrantcflt @0xffff-zhiyan > > > The PR titles makes it seem like we are hard deleting the config. Actually, is it more the case the deprecated configs will stay in the log but we will just ignore them when replaying the log. Is that right? If so, maybe a PR title like "Ignore deprecated configs" would be clearer? > > I think the important distinction is that the deprecated configs _will_ be deleted as a result of ignoring them when replaying the log. At some point we'll delete the last snapshot that contained those deprecated configs. > > @0xffff-zhiyan > > > I have a small concern about it. The core module already has an interface [ConfigurationValidator](https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/controller/ConfigurationValidator.java). Now we define a similar one in metadata module and implement it in core module. Will it cause some confusion? > > That's a good observation, would it maybe make sense to include your logic in ConfigurationValidator and/or ControllerConfigurationValidator? Unfortunately we can't because we need to use it in `ConfigurationDelta` which is in metadata module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
