dajac commented on PR #21350: URL: https://github.com/apache/kafka/pull/21350#issuecomment-3794458977
> The exceptions that come out of scheduleWriteOperation/enqueueLast are very confusing. I think it would help if we were a bit more thorough with the @throwss in the javadocs, not necessarily in this PR. Yes, I agree. > I think the RejectedExecutionException handler within the exceptionally above will never be hit because scheduleWriteOperation will throw it directly? seems that both the future can complete with RejectedExecutionException and scheduleWriteOperation can throw it directly. `scheduleWriteOperation` should not throw `RejectedExecutionException` but the timer and the executor use it internally. The part which annoys me is that `scheduleWriteOperation` can throw synchronously and fail the future. It would be better to only use one pattern. I will try to improve this separately too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
