chia7712 commented on PR #21350:
URL: https://github.com/apache/kafka/pull/21350#issuecomment-3798395485

   > scheduleWriteOperation should not throw RejectedExecutionException but the 
timer and the executor use it internally. The part which annoys me is that 
scheduleWriteOperation can throw synchronously and fail the future. It would be 
better to only use one pattern. I will try to improve this separately too.
   
   agreed. It would be cool to handle both in one fell swoop. The method 
returning `CompletableFuture` should NOT throw exception directly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to