bbejeck commented on code in PR #20955:
URL: https://github.com/apache/kafka/pull/20955#discussion_r2771461842
##########
streams/src/main/java/org/apache/kafka/streams/processor/StateStore.java:
##########
@@ -73,8 +76,55 @@ public interface StateStore {
/**
* Flush any cached data
+ *
+ * @deprecated Use {@link
org.apache.kafka.streams.processor.api.ProcessingContext#commit()
ProcessorContext#commit()}
+ * instead.
+ */
+ @Deprecated
+ default void flush() {
+ // no-op
+ }
+
+ /**
+ * Commit all written records to this StateStore.
+ * <p>
+ * This method <b>CANNOT<b> be called by users from {@link
org.apache.kafka.streams.processor.api.Processor
Review Comment:
```suggestion
* This method <b>CANNOT</b> be called by users from {@link
org.apache.kafka.streams.processor.api.Processor
```
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##########
@@ -484,36 +484,36 @@ void restore(final StateStoreMetadata storeMetadata,
final List<ConsumerRecord<b
/**
* @throws TaskMigratedException recoverable error sending changelog
records that would cause the task to be removed
- * @throws StreamsException fatal error when flushing the state store, for
example sending changelog records failed
- * or flushing state store get IO errors; such
error should cause the thread to die
+ * @throws StreamsException fatal error when commmitting the state store,
for example sending changelog records failed
Review Comment:
```suggestion
* @throws StreamsException fatal error when committing the state store,
for example sending changelog records failed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
