frankvicky commented on code in PR #21408: URL: https://github.com/apache/kafka/pull/21408#discussion_r2779568254
########## streams/src/test/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializerTest.java: ########## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.common.header.Header; +import org.apache.kafka.common.header.Headers; +import org.apache.kafka.common.header.internals.RecordHeaders; +import org.apache.kafka.common.serialization.Serde; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.streams.state.ValueTimestampHeaders; + +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertArrayEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; + +public class ValueTimestampHeadersDeserializerTest { + + private static final String TOPIC = "test-topic"; + private ValueTimestampHeadersSerializer<String> serializer; + private ValueTimestampHeadersDeserializer<String> deserializer; + + @BeforeEach + void setup() { + serializer = new ValueTimestampHeadersSerializer<>(Serdes.String().serializer()); + deserializer = new ValueTimestampHeadersDeserializer<>(Serdes.String().deserializer()); + } + + @AfterEach + void cleanup() { + if (serializer != null) { + serializer.close(); + } + if (deserializer != null) { + deserializer.close(); + } + } + + @Test + public void shouldDeserializeNull() { + final ValueTimestampHeaders<String> result = deserializer.deserialize(TOPIC, null); + assertNull(result); + } + + @Test + public void shouldDeserializeWithEmptyHeaders() { + final Headers headers = new RecordHeaders(); + final ValueTimestampHeaders<String> original = + ValueTimestampHeaders.make("test-value", 123456789L, headers); + + final byte[] serialized = serializer.serialize(TOPIC, original); + final ValueTimestampHeaders<String> deserialized = deserializer.deserialize(TOPIC, serialized); + + assertNotNull(deserialized); + assertEquals("test-value", deserialized.value()); + assertEquals(123456789L, deserialized.timestamp()); + assertNotNull(deserialized.headers()); + assertEquals(0, deserialized.headers().toArray().length); + } + + @Test + public void shouldDeserializeWithSingleHeader() { + final Headers headers = new RecordHeaders() + .add("key1", "value1".getBytes()); + final ValueTimestampHeaders<String> original = + ValueTimestampHeaders.make("test-value", 123456789L, headers); + + final byte[] serialized = serializer.serialize(TOPIC, original); + final ValueTimestampHeaders<String> deserialized = deserializer.deserialize(TOPIC, serialized); + + assertNotNull(deserialized); + assertEquals("test-value", deserialized.value()); + assertEquals(123456789L, deserialized.timestamp()); + + final Headers deserializedHeaders = deserialized.headers(); + assertNotNull(deserializedHeaders); + assertEquals(1, deserializedHeaders.toArray().length); + + final Header header = deserializedHeaders.lastHeader("key1"); + assertNotNull(header); + assertEquals("key1", header.key()); + assertArrayEquals("value1".getBytes(), header.value()); + } + + @Test + public void shouldDeserializeWithMultipleHeaders() { + final Headers headers = new RecordHeaders() + .add("key0", "value0".getBytes()) + .add("key1", "value1".getBytes()) + .add("key2", "value2".getBytes()); + final ValueTimestampHeaders<String> original = + ValueTimestampHeaders.make("test-value", 123456789L, headers); + + final byte[] serialized = serializer.serialize(TOPIC, original); + final ValueTimestampHeaders<String> deserialized = deserializer.deserialize(TOPIC, serialized); + + assertNotNull(deserialized); + assertEquals("test-value", deserialized.value()); + assertEquals(123456789L, deserialized.timestamp()); + + final Headers deserializedHeaders = deserialized.headers(); + assertNotNull(deserializedHeaders); + Header[] headersArray = deserializedHeaders.toArray(); + assertEquals(3, headersArray.length); + + for (int i = 0; i < headersArray.length; i++) { + Header header = headersArray[i]; + assertEquals("key" + i, header.key()); + assertArrayEquals(("value" + i).getBytes(), header.value()); + } + } + + @Test + public void shouldReturnNullWhenSerializingNullValue() { + final Headers headers = new RecordHeaders() + .add("key1", "value1".getBytes()); + final ValueTimestampHeaders<String> original = + ValueTimestampHeaders.makeAllowNullable(null, 123456789L, headers); + + final byte[] serialized = serializer.serialize(TOPIC, original); + assertNull(serialized, "Serializer should return null when value is null"); + + final ValueTimestampHeaders<String> deserialized = deserializer.deserialize(TOPIC, serialized); + assertNull(deserialized, "Deserializer should return null when input is null"); + } + + @Test + public void shouldDeserializeWithHeaderContainingNullValue() { + final Headers headers = new RecordHeaders() + .add("key1", null); + final ValueTimestampHeaders<String> original = + ValueTimestampHeaders.make("test-value", 123456789L, headers); + + final byte[] serialized = serializer.serialize(TOPIC, original); + final ValueTimestampHeaders<String> deserialized = deserializer.deserialize(TOPIC, serialized); + + assertNotNull(deserialized); + assertEquals("test-value", deserialized.value()); + assertEquals(123456789L, deserialized.timestamp()); + + final Header header = deserialized.headers().lastHeader("key1"); + assertNotNull(header); + assertEquals("key1", header.key()); + assertNull(header.value()); + } + + @Test + public void shouldDeserializeWithLargeValue() { Review Comment: My bad, just my imagination case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
