frankvicky commented on code in PR #21408: URL: https://github.com/apache/kafka/pull/21408#discussion_r2781782148
########## streams/src/test/java/org/apache/kafka/streams/state/ValueTimestampHeadersTest.java: ########## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state; + +import org.apache.kafka.common.header.Headers; +import org.apache.kafka.common.header.internals.RecordHeaders; +import org.apache.kafka.streams.state.internals.HeadersSerializer; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertArrayEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class ValueTimestampHeadersTest { + + private static final String VALUE = "test-value"; + private static final long TIMESTAMP = 123456789L; + + @Test + public void shouldCreateInstanceWithMake() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final ValueTimestampHeaders<String> valueTimestampHeaders = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers); + + assertNotNull(valueTimestampHeaders); + assertEquals(VALUE, valueTimestampHeaders.value()); + assertEquals(TIMESTAMP, valueTimestampHeaders.timestamp()); + assertEquals(headers, valueTimestampHeaders.headers()); + } + + @Test + public void shouldReturnNullWhenValueIsNullWithMake() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final ValueTimestampHeaders<String> valueTimestampHeaders = ValueTimestampHeaders.make(null, TIMESTAMP, headers); + + assertNull(valueTimestampHeaders); + } + + @Test + public void shouldCreateInstanceWithMakeAllowNullable() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final ValueTimestampHeaders<String> valueTimestampHeaders = ValueTimestampHeaders.makeAllowNullable(VALUE, TIMESTAMP, headers); + + assertNotNull(valueTimestampHeaders); + assertEquals(VALUE, valueTimestampHeaders.value()); + assertEquals(TIMESTAMP, valueTimestampHeaders.timestamp()); + assertEquals(headers, valueTimestampHeaders.headers()); + } + + @Test + public void shouldCreateInstanceWithNullValueUsingMakeAllowNullable() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final ValueTimestampHeaders<String> valueTimestampHeaders = ValueTimestampHeaders.makeAllowNullable(null, TIMESTAMP, headers); + + assertNotNull(valueTimestampHeaders); + assertNull(valueTimestampHeaders.value()); + assertEquals(TIMESTAMP, valueTimestampHeaders.timestamp()); + assertEquals(headers, valueTimestampHeaders.headers()); + } + + @Test + public void shouldCreateEmptyHeadersWhenHeadersAreNull() { + final ValueTimestampHeaders<String> valueTimestampHeaders = ValueTimestampHeaders.make(VALUE, TIMESTAMP, null); + + assertNotNull(valueTimestampHeaders); + assertNotNull(valueTimestampHeaders.headers()); + assertEquals(0, valueTimestampHeaders.headers().toArray().length); + } + + @Test + public void shouldGetValueOrNull() { + final Headers headers = new RecordHeaders(); + final ValueTimestampHeaders<String> valueTimestampHeaders = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers); + + assertEquals(VALUE, ValueTimestampHeaders.getValueOrNull(valueTimestampHeaders)); + assertNull(ValueTimestampHeaders.getValueOrNull(null)); + } + + @Test + public void shouldBeEqualWhenSameValues() { + final Headers headers1 = new RecordHeaders().add("key1", "value1".getBytes()); + final Headers headers2 = new RecordHeaders().add("key1", "value1".getBytes()); + + final ValueTimestampHeaders<String> valueTimestampHeaders1 = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers1); + final ValueTimestampHeaders<String> valueTimestampHeaders2 = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers2); + + assertEquals(valueTimestampHeaders1, valueTimestampHeaders2); + assertEquals(valueTimestampHeaders1.hashCode(), valueTimestampHeaders2.hashCode()); + } + + @Test + public void shouldNotBeEqualWhenDifferentValues() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + + final ValueTimestampHeaders<String> valueTimestampHeaders1 = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers); + final ValueTimestampHeaders<String> valueTimestampHeaders2 = ValueTimestampHeaders.make("different", TIMESTAMP, headers); + + assertNotEquals(valueTimestampHeaders1, valueTimestampHeaders2); + } + + @Test + public void shouldNotBeEqualWhenDifferentTimestamps() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + + final ValueTimestampHeaders<String> valueTimestampHeaders1 = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers); + final ValueTimestampHeaders<String> valueTimestampHeaders2 = ValueTimestampHeaders.make(VALUE, TIMESTAMP + 1, headers); + + assertNotEquals(valueTimestampHeaders1, valueTimestampHeaders2); + } + + @Test + public void shouldNotBeEqualWhenDifferentHeaders() { + final Headers headers1 = new RecordHeaders().add("key1", "value1".getBytes()); + final Headers headers2 = new RecordHeaders().add("key2", "value2".getBytes()); + + final ValueTimestampHeaders<String> valueTimestampHeaders1 = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers1); + final ValueTimestampHeaders<String> valueTimestampHeaders2 = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers2); + + assertNotEquals(valueTimestampHeaders1, valueTimestampHeaders2); + } + + @Test + public void shouldBeEqualToItself() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final ValueTimestampHeaders<String> valueTimestampHeaders = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers); + + assertEquals(valueTimestampHeaders, valueTimestampHeaders); + } + + @Test + public void shouldHaveCorrectToString() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final ValueTimestampHeaders<String> valueTimestampHeaders = ValueTimestampHeaders.make(VALUE, TIMESTAMP, headers); + + final String toString = valueTimestampHeaders.toString(); + assertNotNull(toString); + assertTrue(toString.contains("value=" + VALUE)); + assertTrue(toString.contains("timestamp=" + TIMESTAMP)); + } + + @Test + public void shouldCreateInstanceWithMakeWithRawHeaders() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final byte[] rawHeaders = new HeadersSerializer().serialize("", headers); + + final ValueTimestampHeaders<String> valueTimestampHeaders = + ValueTimestampHeaders.makeWithRawHeaders(VALUE, TIMESTAMP, rawHeaders); + + assertNotNull(valueTimestampHeaders); + assertEquals(VALUE, valueTimestampHeaders.value()); + assertEquals(TIMESTAMP, valueTimestampHeaders.timestamp()); + + final Headers deserializedHeaders = valueTimestampHeaders.headers(); + assertNotNull(deserializedHeaders); + assertEquals(1, deserializedHeaders.toArray().length); + assertEquals("key1", deserializedHeaders.lastHeader("key1").key()); + assertArrayEquals("value1".getBytes(), deserializedHeaders.lastHeader("key1").value()); + } + + @Test + public void shouldDeserializeHeaderLazily() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final byte[] rawHeaders = new HeadersSerializer().serialize("", headers); + + final ValueTimestampHeaders<String> valueTimestampHeaders = + ValueTimestampHeaders.makeWithRawHeaders(VALUE, TIMESTAMP, rawHeaders); + + assertNotNull(valueTimestampHeaders); + assertEquals(VALUE, valueTimestampHeaders.value()); + assertEquals(TIMESTAMP, valueTimestampHeaders.timestamp()); + assertNull(valueTimestampHeaders.headers, "should be null before invocation of headers()"); + valueTimestampHeaders.headers(); + assertNotNull(valueTimestampHeaders.headers, "should be deserialize after invocation of headers()"); + assertEquals(headers, valueTimestampHeaders.headers); + assertEquals(headers, valueTimestampHeaders.headers()); + } + + @Test + public void shouldReturnNullWhenValueIsNullWithMakeWithRawHeaders() { + final Headers headers = new RecordHeaders().add("key1", "value1".getBytes()); + final byte[] rawHeaders = new HeadersSerializer().serialize("", headers); + + final ValueTimestampHeaders<String> valueTimestampHeaders = + ValueTimestampHeaders.makeWithRawHeaders(null, TIMESTAMP, rawHeaders); Review Comment: We should postpone this till we start dealing with lazy deserialization issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
