see-quick commented on code in PR #21384:
URL: https://github.com/apache/kafka/pull/21384#discussion_r2792709072
##########
server/src/main/java/org/apache/kafka/server/config/DynamicBrokerConfig.java:
##########
@@ -279,4 +279,8 @@ public static class DynamicReplicationConfig {
public static final Set<String> RECONFIGURABLE_CONFIGS = Set.of(
ReplicationConfigs.FOLLOWER_FETCH_LAST_TIERED_OFFSET_ENABLE_CONFIG);
}
+
+ public static class DynamicQuotaConfig {
Review Comment:
Yeah, I think it make code more readable at least for me. Like I didn't want
to re-write all these properties into `Dynamic<class-name>.java`:
```java
public static final Set<String> ALL_DYNAMIC_CONFIGS = Stream.of(
DYNAMIC_SECURITY_CONFIGS,
LogCleaner.RECONFIGURABLE_CONFIGS,
DynamicLogConfig.RECONFIGURABLE_CONFIGS,
DynamicThreadPool.RECONFIGURABLE_CONFIGS,
List.of(MetricConfigs.METRIC_REPORTER_CLASSES_CONFIG),
DynamicListenerConfig.RECONFIGURABLE_CONFIGS,
SocketServer.RECONFIGURABLE_CONFIGS,
DYNAMIC_PRODUCER_STATE_MANAGER_CONFIGS,
DynamicRemoteLogConfig.RECONFIGURABLE_CONFIGS,
DynamicReplicationConfig.RECONFIGURABLE_CONFIGS,
List.of(AbstractConfig.CONFIG_PROVIDERS_CONFIG),
GroupCoordinatorConfig.RECONFIGURABLE_CONFIGS,
DynamicQuotaConfig.RECONFIGURABLE_CONFIGS,
ShareCoordinatorConfig.RECONFIGURABLE_CONFIGS)
.flatMap(Collection::stream)
.collect(Collectors.toUnmodifiableSet());
```
because you can see that some of them using that pattern
`DynamicThreadPool.RECONFIGURABLE_CONFIGS` or
`DynamicLogConfig.RECONFIGURABLE_CONFIGS`. Like for instance when seeing
`QuotaConfig.BROKER_QUOTA_CONFIGS` it doesn't give me a feeling that it's
dynamic configuration I have to go deep into the code to see it actually....
(maybe I am just too picky sorry :D)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
