see-quick commented on code in PR #21384:
URL: https://github.com/apache/kafka/pull/21384#discussion_r2792734958
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -56,7 +56,9 @@ import scala.jdk.OptionConverters.RichOptional
object KafkaConfig {
def main(args: Array[String]): Unit = {
- System.out.println(configDef.toHtml(4, (config: String) =>
"brokerconfigs_" + config,
+ val combined = new ConfigDef(configDef)
+ QuotaConfig.brokerQuotaConfigs().configKeys().forEach((_, v) =>
combined.define(v))
Review Comment:
Yeah that would be good idea, I have added comment there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
