mimaison commented on code in PR #21273:
URL: https://github.com/apache/kafka/pull/21273#discussion_r2832477453
##########
clients/src/main/java/org/apache/kafka/clients/admin/LogDirDescription.java:
##########
@@ -33,16 +33,18 @@ public class LogDirDescription {
private final ApiException error;
private final OptionalLong totalBytes;
private final OptionalLong usableBytes;
+ private final boolean isCordoned;
public LogDirDescription(ApiException error, Map<TopicPartition,
ReplicaInfo> replicaInfos) {
- this(error, replicaInfos, UNKNOWN_VOLUME_BYTES, UNKNOWN_VOLUME_BYTES);
+ this(error, replicaInfos, UNKNOWN_VOLUME_BYTES, UNKNOWN_VOLUME_BYTES,
false);
}
- public LogDirDescription(ApiException error, Map<TopicPartition,
ReplicaInfo> replicaInfos, long totalBytes, long usableBytes) {
+ public LogDirDescription(ApiException error, Map<TopicPartition,
ReplicaInfo> replicaInfos, long totalBytes, long usableBytes, boolean
isCordoned) {
Review Comment:
Yes I agree it's safer to keep the existing constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
