chia7712 commented on code in PR #21273:
URL: https://github.com/apache/kafka/pull/21273#discussion_r2846972233
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -577,8 +577,20 @@ class DynamicLogConfig(logManager: LogManager) extends
BrokerReconfigurable with
}
}
+ def validateCordonedLogDirs(): Unit = {
Review Comment:
> The KIP promises to update the [Decommissioning
brokers](https://kafka.apache.org/42/operations/basic-kafka-operations/#decommissioning-brokers)
section in the docs. That will also include the steps to decommission a log
directory.The KIP promises to update the [Decommissioning
brokers](https://kafka.apache.org/42/operations/basic-kafka-operations/#decommissioning-brokers)
section in the docs. That will also include the steps to decommission a log
directory.
Is this a follow-up too?
> I'll either add these to https://github.com/apache/kafka/pull/21523 or in
a follow up PR.I'll either add these to
https://github.com/apache/kafka/pull/21523 or in a follow up PR.
we could have a follow-up task to improve the test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
