AndrewJSchofield commented on code in PR #21633:
URL: https://github.com/apache/kafka/pull/21633#discussion_r2906977420


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupConfigTest.java:
##########
@@ -280,6 +303,155 @@ public void testInvalidConfigName() {
         assertThrows(InvalidConfigurationException.class, () -> 
GroupConfig.validate(props, createGroupCoordinatorConfig(), 
createShareGroupConfig()));
     }
 
+    @Test

Review Comment:
   I'm not sure what this test shows. How does it validate "uses all group type 
defaults"? Maybe there's a better name for it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to