majialoong commented on code in PR #21633:
URL: https://github.com/apache/kafka/pull/21633#discussion_r2912624164
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupConfigTest.java:
##########
@@ -280,6 +303,155 @@ public void testInvalidConfigName() {
assertThrows(InvalidConfigurationException.class, () ->
GroupConfig.validate(props, createGroupCoordinatorConfig(),
createShareGroupConfig()));
}
+ @Test
Review Comment:
This test was introduced in #21593 mainly to verify that `validate()` uses
configs for all group types, i.e. it uses `extractGroupConfigMap` rather than
`extractConsumerGroupConfigMap`.
I agree with your point that both the previous test name and the test itself
could be improved. In my latest commit, I renamed it to
`testValidateWithAllGroupTypeConfigs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
