mjsax commented on code in PR #21580:
URL: https://github.com/apache/kafka/pull/21580#discussion_r2922690557
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java:
##########
@@ -192,9 +192,11 @@ private ValueAndTimestamp<VOut> transformValue(final K
key, final ValueAndTimest
new RecordHeaders()
));
- final ValueAndTimestamp<VOut> result = ValueAndTimestamp.make(
- valueTransformer.transform(key,
getValueOrNull(valueAndTimestamp)),
- valueAndTimestamp == null ? UNKNOWN :
valueAndTimestamp.timestamp());
+ final ValueTimestampHeaders<VOut> result =
ValueTimestampHeaders.make(
+ valueTransformer.transform(key,
getValueOrNull(valueTimestampHeaders)),
+ valueTimestampHeaders == null ? UNKNOWN :
valueTimestampHeaders.timestamp(),
+ valueTimestampHeaders == null ? null :
valueTimestampHeaders.headers()
Review Comment:
similar question as for `KTable#mapValues` -- do we pass `headers()` or `new
RecordHeaders()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
