lucliu1108 commented on PR #21692: URL: https://github.com/apache/kafka/pull/21692#issuecomment-4050828768
@lucasbru @squah-confluent @dajac Based on the discussion, i moved the logic to resolve topic ids for `OffsetCommit` API to `KafkaAPIs` where topicName is resolved. I changed the block logic a little with the assumption that: 1. If `topic.topicId == Uuid.ZERO_UUID`, then it couldn't of an OffsetCommit.API_VERSION>=10 2. If OffsetCommit.API_VERSION>=10, then topicId could't be ZERO_UUID (enforced by `OffsetCommitRequest#build() method). Is my assumption correct? Not sure if there's any gaps in between the two situations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
