lucliu1108 commented on PR #21692: URL: https://github.com/apache/kafka/pull/21692#issuecomment-4058185567
Thanks for the review! I made the following changes: - For `OffsetCommit`, `KafkaApis` does the `topicId` resolving - For `TxnOffsetCommit`, since there's no topicId yet, the `OffsetMetadataManager` does the topicId resolving. - For both `OffsetCommit` and `TxnOffsetCommit`, there's a ZERO_UUID check for the topicId, where it fallback to old validator. An `ILLEGAL_GENERATION` exception will be throw if the validation fail. - For original `OffsetMetadataManagerTest`, since the previous check is enforced, i added random uuids to some of the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
