mjsax commented on code in PR #21737:
URL: https://github.com/apache/kafka/pull/21737#discussion_r2928170189
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -530,6 +530,7 @@ private void onSuccessResponse(final
StreamsGroupHeartbeatResponse response, fin
heartbeatRequestState.onSuccessfulAttempt(currentTimeMs);
heartbeatState.setEndpointInformationEpoch(data.endpointInformationEpoch());
streamsRebalanceData.setHeartbeatIntervalMs(data.heartbeatIntervalMs());
+
streamsRebalanceData.setTaskOffsetIntervalMs(data.taskOffsetIntervalMs());
Review Comment:
This is an open question -- adding the config to _every_ response atm -- the
KIP seems to actually have a gap, not listing this field in
`StreamsHeartbeatResponse` RPC, even if it's already in the code.
So the KIP does not specify if this is ok (similar to
`heartbeat.interval.ms` which we also send each time), or if we should want to
send this only if the config was changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
