lucasbru commented on code in PR #21722:
URL: https://github.com/apache/kafka/pull/21722#discussion_r2929925507


##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -323,6 +323,11 @@ public void 
shouldRestoreStateFromSourceTopicForReadOnlyStore(final boolean useN
             startApplicationAndWaitUntilRunning(kafkaStreams);
         }
 
+        waitForCondition(
+            () -> restored.get() > 0,
+            10_000,
+            () -> "Did not restore any state within the timeout period."
+        );

Review Comment:
   I think the problem may be that we are not returning `ASSIGNMENT_DELAYED` 
anymore when the target assignment is offloaded. That means the application 
will be thinking it's already running, when it's not. 
   
   I think it would be good to still set `ASSIGNMENT_DELAYED` status, which is 
exactly meant to resolve this problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to