dajac commented on code in PR #21722:
URL: https://github.com/apache/kafka/pull/21722#discussion_r2940703362
##########
tests/kafkatest/tests/streams/streams_smoke_test.py:
##########
@@ -50,8 +50,14 @@ def __init__(self, test_context):
@matrix(processing_guarantee=['exactly_once_v2', 'at_least_once'],
crash=[True, False],
metadata_quorum=[quorum.combined_kraft],
- group_protocol=["classic", "streams"])
- def test_streams(self, processing_guarantee, crash, metadata_quorum,
group_protocol):
+ group_protocol=["classic"],
+ enable_assignment_batching=[False])
+ @matrix(processing_guarantee=['exactly_once_v2', 'at_least_once'],
+ crash=[True, False],
+ metadata_quorum=[quorum.combined_kraft],
+ group_protocol=["streams"],
+ enable_assignment_batching=[False, True])
Review Comment:
I think that we should determine the most appropriate tests to parameterise.
It does not make sense to duplicate all the tests. For the context, I have
asked @squah-confluent to parameterise some integration and system tests with
the batching disabled to ensure coverage for it. @lucasbru What are the
base/common tests in your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
