mimaison commented on code in PR #21576: URL: https://github.com/apache/kafka/pull/21576#discussion_r2930162728
########## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMetricsTest.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.connect.mirror; + +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.metrics.Metrics; +import org.apache.kafka.common.metrics.PluginMetrics; +import org.apache.kafka.common.metrics.internals.PluginMetricsImpl; +import org.apache.kafka.connect.runtime.ConnectorConfig; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.util.HashMap; +import java.util.Map; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class MirrorMetricsTest { + + private static final String SOURCE = "source"; + private static final String TARGET = "target"; + private static final TopicPartition TP = new TopicPartition("topic", 0); + private static final TopicPartition SOURCE_TP = new TopicPartition(SOURCE + "." + TP.topic(), TP.partition()); + private static final String GROUP = "my-group"; + + private final Map<String, String> configs = new HashMap<>(); + private final Metrics metrics = new Metrics(); + private final PluginMetrics pluginMetrics = new PluginMetricsImpl(metrics, Map.of()); + + @BeforeEach + public void setUp() { + configs.put(ConnectorConfig.NAME_CONFIG, "name"); + configs.put(MirrorConnectorConfig.SOURCE_CLUSTER_ALIAS, SOURCE); + configs.put(MirrorConnectorConfig.TARGET_CLUSTER_ALIAS, TARGET); + configs.put(MirrorConnectorConfig.TASK_INDEX, "0"); + } + + @Test + public void testSourceTags() { + configs.put(ConnectorConfig.CONNECTOR_CLASS_CONFIG, MirrorSourceConnector.class.getName()); + configs.put(MirrorSourceTaskConfig.TASK_TOPIC_PARTITIONS, TP.toString()); + MirrorSourceTaskConfig taskConfig = new MirrorSourceTaskConfig(configs); + MirrorSourceMetrics sourceMetrics = new MirrorSourceMetrics(pluginMetrics, taskConfig); + + sourceMetrics.countRecord(SOURCE_TP); + // 12 MirrorSourceConnector metrics + the metrics count metric + assertEquals(13, metrics.metrics().size()); + Map<String, String> tags = metrics.metrics().keySet().stream() + .filter(m -> m.group().equals("plugins")) + .findFirst() + .get().tags(); + assertEquals(SOURCE, tags.get("source")); Review Comment: The `connector` and `task` tags are injected by the runtime. Here we are not mocking that logic as we build `pluginMetrics` without any tags: `new PluginMetricsImpl(metrics, Map.of());`. This is why I'm not checking these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
