mimaison commented on code in PR #21576:
URL: https://github.com/apache/kafka/pull/21576#discussion_r2930352606
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##########
@@ -1001,6 +1007,76 @@ public void testReplicateFromLatest() throws Exception {
});
}
+ @Test
+ public void testConnectorMetrics() throws InterruptedException,
ExecutionException {
+ // one way replication from primary to backup
+ mm2Props.put(BACKUP_CLUSTER_ALIAS + "->" + PRIMARY_CLUSTER_ALIAS +
".enabled", "false");
+ mm2Props.put(PRIMARY_CLUSTER_ALIAS + "->" + BACKUP_CLUSTER_ALIAS + "."
+ MirrorConnectorConfig.METRIC_NAMES_FORMAT, METRIC_NAMES_NEW);
+ mm2Config = new MirrorMakerConfig(mm2Props);
+
+ String topic = "test-topic-metrics";
+ primary.kafka().createTopic(topic);
+ try (KafkaProducer<byte[], byte[]> producer =
primary.kafka().createProducer(Map.of())) {
+ for (int i = 0; i < NUM_RECORDS_PRODUCED; i++) {
+ producer.send(new ProducerRecord<>(topic, ("value" +
i).getBytes())).get();
+ }
+ }
+
+ waitUntilMirrorMakerIsRunning(backup,
+ List.of(MirrorSourceConnector.class,
MirrorCheckpointConnector.class),
+ mm2Config,
+ PRIMARY_CLUSTER_ALIAS,
+ BACKUP_CLUSTER_ALIAS);
+
+ try (KafkaConsumer<byte[], byte[]> consumer =
primary.kafka().createConsumer(
+ Map.of("group.id", "consumer-group-metrics",
+ ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest",
+ ConsumerConfig.FETCH_MAX_BYTES_CONFIG, "1"))) {
+ int consumed = 0;
+ consumer.subscribe(List.of(topic));
+ while (consumed < NUM_RECORDS_PRODUCED) {
+ ConsumerRecords<byte[], byte[]> records =
consumer.poll(Duration.ofMillis(100));
+ consumer.commitSync();
+ consumed += records.count();
+ }
+ }
+
+ Set<String> expectedSourceTags = Set.of("connector", "task", "source",
"target", "topic", "partition");
+ Set<String> expectedCheckpointTags = Set.of("connector", "task",
"source", "target", "group", "topic", "partition");
+ // We have 4 topics totalling 13 partitions
+ // primary.test-topic - 10 partitions
+ // primary.test-topic-no-checkpoints - 1 partition
+ // primary.test-topic-metrics - 1 partition
+ // primary.heartbeats - 1 partition
+ // There are 12 metrics per partition, 12 x 13 = 156
+ int expectedSourceCount = 156;
+ // We have 1 consumer group (consumer-group-metrics)
+ // There are 4 metrics per group
+ int expectedCheckpointCount = 4;
+ waitForCondition(() -> {
+ Set<ConnectMetrics> allConnectMetrics = backup.allConnectMetrics();
+ int sourceMetrics = 0;
+ int checkpointMetrics = 0;
+ for (ConnectMetrics connectMetrics : allConnectMetrics) {
+ Set<MetricName> metrics =
connectMetrics.metrics().metrics().keySet();
+ for (MetricName metricName : metrics) {
+ if (metricName.group().equals("plugins")) {
+ Map<String, String> tags = metricName.tags();
+ if
(MirrorSourceConnector.class.getSimpleName().equals(tags.get("connector"))) {
+ assertEquals(expectedSourceTags, tags.keySet());
+ sourceMetrics++;
+ }
+ if
(MirrorCheckpointConnector.class.getSimpleName().equals(tags.get("connector")))
{
+ assertEquals(expectedCheckpointTags,
tags.keySet());
+ checkpointMetrics++;
+ }
+ }
+ }
+ }
+ return sourceMetrics == expectedSourceCount && checkpointMetrics
== expectedCheckpointCount;
+ }, 10_000L, "Unable to find the MirrorMaker metrics");
Review Comment:
Right, I bumped the timeout to 30 secs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
