bbejeck commented on code in PR #21750:
URL: https://github.com/apache/kafka/pull/21750#discussion_r2934182461
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -396,6 +391,16 @@ private List<ColumnFamilyHandle>
mergeColumnFamilyHandleLists(final List<ColumnF
return columnFamilies;
}
+ private void writePosition() {
+ validateStoreOpen();
+ try {
+ cfAccessor.commit(dbAccessor, position);
+ } catch (final RocksDBException e) {
+ // TODO: fatal error?
+ throw new RuntimeException(e);
Review Comment:
I would say since the `position` is for IQ only and doesn't affect data
correctness I'd say log a `WARN`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
