bbejeck commented on code in PR #21750:
URL: https://github.com/apache/kafka/pull/21750#discussion_r2942662044
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -396,6 +397,15 @@ private List<ColumnFamilyHandle>
mergeColumnFamilyHandleLists(final List<ColumnF
return columnFamilies;
}
+ public final void writePosition() {
+ validateStoreOpen();
+ try {
+ cfAccessor.commit(dbAccessor, position);
+ } catch (final RocksDBException e) {
+ log.warn("Error while commiting position for store {}", name, e);
Review Comment:
```suggestion
log.warn("Error while committing position for store {}", name,
e);
```
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -396,6 +397,15 @@ private List<ColumnFamilyHandle>
mergeColumnFamilyHandleLists(final List<ColumnF
return columnFamilies;
}
+ public final void writePosition() {
+ validateStoreOpen();
+ try {
+ cfAccessor.commit(dbAccessor, position);
+ } catch (final RocksDBException e) {
+ log.warn("Error while commiting position for store {}", name, e);
Review Comment:
I have an additional thought here, I'm wondering if we get configs through
`InternalProcessorContext` and check if `IQ` is enabled and then throw. At
this point just food for thought and we can take this on in a follow-up PR
should we decide to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
