josefk31 commented on code in PR #21028:
URL: https://github.com/apache/kafka/pull/21028#discussion_r2941675336
##########
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -535,6 +555,8 @@ private RaftClientTestContext(
this.metrics = metrics;
this.externalKRaftMetrics = externalKRaftMetrics;
this.listener = listener;
+ this.fetchSnapshotMaxBytes = fetchSnapshotMaxBytes;
Review Comment:
It's used to record what value was stored in the `quorumConfig`
1. QuorumConfig where it is used to create `fetchSnapshotRequest`
2. We use it to check fetchSnapshotRequests to see if they are using the
configured value where appropriate
The `RaftClientTestContext` seems to have a pattern of storing whatever
variables were written to the `quorumConfig` as finalized fields. It does not
itself store a reference to the `quorumConfig`. So I think that's why I ended
up going in this direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
