josefk31 commented on code in PR #21028:
URL: https://github.com/apache/kafka/pull/21028#discussion_r2954426801
##########
raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftLogTest.java:
##########
@@ -1083,23 +1081,66 @@ public void testSegmentsLessThanLatestSnapshot() throws
IOException {
);
}
+
+ @ParameterizedTest
+ @ValueSource(ints = {1, 2, 3})
+ public void testReadRespectsMaxSizeInBytes(int expectedBatches) throws
IOException {
+ // 5 records are written in batches of 101 bytes each (at time of
writing).
+ int magicMaxBatchSizeBytes = 101;
+ MetadataLogConfig config = createMetadataLogConfig(
+ 10240,
+ 10 * 1000,
+ 10240,
+ 60 * 1000,
+ magicMaxBatchSizeBytes
+ );
Review Comment:
8 spaces for continuations is consistent with the rest of the file. I'd
prefer to just create a "whitespace" specific PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
