squah-confluent commented on code in PR #21692:
URL: https://github.com/apache/kafka/pull/21692#discussion_r2944307988
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroupTest.java:
##########
@@ -934,14 +940,181 @@ public void testValidateOffsetCommit(short version) {
}
}
+ @ParameterizedTest
Review Comment:
@lucliu1108 could we avoid duplicating the checks for classic members that
are already present in `testValidateTransactionalOffsetCommit` and
`testValidateOffsetCommit`?
Since we are adding `testValidateOffsetCommitWithClassicProtocolMember`, we
can remove the classic member checks from the two tests above, and for
consistency, move the consumer protocol checks for `request epoch > member
epoch` into `testValidateOffsetCommitWithAssignmentEpochValidation` and
`testValidateOffsetCommitWithPartitionPendingRevocation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
