FrankYang0529 commented on code in PR #21080:
URL: https://github.com/apache/kafka/pull/21080#discussion_r2945865967
##########
tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java:
##########
@@ -664,14 +665,18 @@ private static class ReplicaFetcherBlockingSend {
metrics,
time,
"replica-fetcher",
- new HashMap<String, String>() {{
+ new HashMap<>() {{
put("broker-id", sourceNode.idString());
put("fetcher-id", String.valueOf(fetcherId));
}},
false,
channelBuilder,
logContext
);
+ NetworkClient.BootstrapConfiguration bootstrapConfiguration = new
NetworkClient.BootstrapConfiguration(
+
consumerConfig.getList(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG),
+
ClientDnsLookup.forConfig(consumerConfig.getString(CommonClientConfigs.CLIENT_DNS_LOOKUP_CONFIG)),
+
consumerConfig.getLong(CommonClientConfigs.RECONNECT_BACKOFF_MS_CONFIG));
Review Comment:
It looks like `BOOTSTRAP_RESOLVE_TIMEOUT_MS_CONFIG` is defined but not used
in this PR. Do you want to change `RECONNECT_BACKOFF_MS_CONFIG` to
`BOOTSTRAP_RESOLVE_TIMEOUT_MS_CONFIG` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
