chia7712 commented on code in PR #21080:
URL: https://github.com/apache/kafka/pull/21080#discussion_r2956270277
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java:
##########
@@ -148,6 +149,18 @@ public void rebootstrap(long now) {
AdminMetadataManager.this.rebootstrap(now);
}
+ @Override
+ public boolean isBootstrapped() {
+ // AdminClient bootstraps during construction via
metadataManager.update(Cluster.bootstrap(...))
+ // so we check if the bootstrap cluster has been set
+ return bootstrapCluster != null;
+ }
+
+ @Override
+ public void bootstrap(List<InetSocketAddress> addresses) {
+ // AdminClient handles bootstrap during construction, so this
method is not used
Review Comment:
KIP-909 states "Consumer, Producer, and Admin Clients: The bootstrap code
will be changed.", so this comment is not correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
