sebastienviale commented on code in PR #22673:
URL: https://github.com/apache/kafka/pull/22673#discussion_r3485482643
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -303,24 +309,27 @@ public TopologyTestDriver(final Topology topology,
* @param topology the topology to be tested
* @param config the configuration for the topology
* @param initialWallClockTime the initial value of internally mocked
wall-clock time
+ * @deprecated Use {@link TopologyTestDriverBuilder} instead.
*/
+ @Deprecated(since = "4.4")
public TopologyTestDriver(final Topology topology,
final Properties config,
final Instant initialWallClockTime) {
this(
- topology.internalTopologyBuilder,
- config,
- initialWallClockTime == null ? System.currentTimeMillis() :
initialWallClockTime.toEpochMilli());
+ topology.internalTopologyBuilder,
+ config,
+ initialWallClockTime == null ? System.currentTimeMillis() :
initialWallClockTime.toEpochMilli());
}
/**
- * Create a new test diver instance.
+ * Create a new test diver instance. Package-private core constructor
shared by the (deprecated)
+ * public constructors and by {@link TopologyTestDriverBuilder}, which is
the blessed entry point.
*
* @param builder builder for the topology to be tested
* @param config the configuration for the topology
* @param initialWallClockTimeMs the initial value of internally mocked
wall-clock time
*/
- private TopologyTestDriver(final InternalTopologyBuilder builder,
+ TopologyTestDriver(final InternalTopologyBuilder builder,
final Properties config,
final long initialWallClockTimeMs) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
