frankvicky commented on code in PR #21080:
URL: https://github.com/apache/kafka/pull/21080#discussion_r3499736486
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -1544,7 +1591,13 @@ private void processRequests() {
// Wait for network responses.
log.trace("Entering KafkaClient#poll(timeout={})",
pollTimeout);
- List<ClientResponse> responses = client.poll(Math.max(0L,
pollTimeout), now);
+ List<ClientResponse> responses;
+ try {
+ responses = client.poll(Math.max(0L, pollTimeout), now);
+ } catch (BootstrapResolutionException e) {
+ failAllPendingCalls(e, now);
+ break;
Review Comment:
In the latest commit, `AdminMetadataManager` now persists a
`bootstrapFatalException` (set by `AdminMetadataUpdater.bootstrapFailed`), and
`AdminClientRunnable.enqueue` checks it before queueing, failing new calls
immediately with `BootstrapResolutionException`. So even though the I/O thread
still exits after break, every subsequent API call surfaces the bootstrap error
— covered by the second `admin.listTopics().names().get()` in
`testAdminBootstrapResolutionExceptionPropagated`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
