lianetm commented on code in PR #21080:
URL: https://github.com/apache/kafka/pull/21080#discussion_r3580357456
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -64,7 +64,10 @@ public class CommonClientConfigs {
public static final long DEFAULT_BOOTSTRAP_RESOLVE_TIMEOUT_MS = 2 * 60 *
1000L;
public static final String BOOTSTRAP_RESOLVE_TIMEOUT_MS_DOC = "Maximum
amount of time clients can spend trying to" +
" resolve for the bootstrap server address. If the resolution cannot
be completed within this timeframe, a " +
- "<code>BootstrapResolutionException</code> will be thrown.";
+ "<code>BootstrapResolutionException</code> will be thrown. Setting
this to <code>0</code> means the client" +
+ " attempts resolution once without waiting for it to complete: the
resolution is triggered on the first" +
+ " poll and its result is checked on the next; if the address is not
resolved by then, a" +
Review Comment:
the concept of poll (network poll) here may be too low level for a
user-facing config imo , wdyt?.
We could generalize maybe, loosely saying that it is expect to be resolved
immediately/right away (e.g., "..the client attempts resolution once and checks
the result right after, fails with BootstrapEx if bootstrap did not complete").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
