adikou commented on code in PR #22271:
URL: https://github.com/apache/kafka/pull/22271#discussion_r3520553939
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##########
@@ -1004,8 +1062,42 @@ synchronized void movePartitionToEnd(TopicPartition tp) {
assignment.moveToEnd(tp);
}
- public synchronized Optional<ConsumerRebalanceListener>
rebalanceListener() {
- return rebalanceListener;
+ private synchronized Optional<RebalanceListener> rebalanceListener() {
+ return Optional.ofNullable(rebalanceListener.get());
+ }
+
+ private synchronized Consumer<?, ?> rebalanceConsumerOrThrow() {
+ return Optional.ofNullable(rebalanceConsumer.get())
+ .orElseThrow(() -> new IllegalStateException("Rebalance
consumer has not been initialized"));
+ }
+
+ /** @return true if a {@link RebalanceListener} has been registered with
this subscription. */
+ public synchronized boolean hasRebalanceListener() {
+ return rebalanceListener.get() != null;
+ }
+
+ /** Invoke {@link RebalanceListener#onPartitionsAssigned(Collection,
RebalanceConsumer)} on the given partitions.*/
+ public void onPartitionsAssigned(Collection<TopicPartition> partitions) {
+ rebalanceListener().ifPresent(rl ->
invokeRebalanceListener(partitions, rl::onPartitionsAssigned));
Review Comment:
I went through the flow and this is correct, we fetch both references from
the same monitor but at different times so yeah it can end up that way.
I've fixed this to fetch both under the same critical section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
