adikou commented on code in PR #22271:
URL: https://github.com/apache/kafka/pull/22271#discussion_r3580854420
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##########
@@ -189,20 +196,47 @@ else if (this.subscriptionType != type)
throw new IllegalStateException(SUBSCRIPTION_EXCEPTION_MESSAGE);
}
+ /**
+ * deprecated Visible for testing only. Will be removed in a follow-on
cleanup PR.
Review Comment:
I can't add it yet because it's breaking compilation because it shouts at me
with -Werror.
If I fix the call sites the PR unfortunately blows up. That's why I created
https://issues.apache.org/jira/browse/KAFKA-20684 to get to that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
