aliehsaeedii commented on code in PR #22570:
URL: https://github.com/apache/kafka/pull/22570#discussion_r3532045579
##########
streams/src/main/java/org/apache/kafka/streams/processor/StreamPartitioner.java:
##########
@@ -53,17 +54,23 @@
@FunctionalInterface
public interface StreamPartitioner<K, V> {
+ @Deprecated(since = "4.4", forRemoval = true)
+ Optional<Set<Integer>> partitions(String topic, K key, V value, int
numPartitions);
Review Comment:
The deprecated method lost its javadoc entirely (it moved to the new
overload). Since this stays part of the public API until removal, it should
keep a `@deprecated` javadoc tag pointing at the replacement, e.g.:
```java
/**
* @deprecated Since 4.4. Use {@link #partitions(String, Object, Object,
Headers, int)} instead.
*/
```
This also answers the question from the other thread: yes, the javadoc tag
is expected alongside the annotation (checkstyle's `MissingDeprecated`
conventions and the generated API docs both want it), and mentioning the
planned removal there is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
