UladzislauBlok commented on code in PR #22570:
URL: https://github.com/apache/kafka/pull/22570#discussion_r3597490750
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStreamPartitioner.java:
##########
@@ -32,9 +34,15 @@ public DefaultStreamPartitioner(final Serializer<K>
keySerializer) {
this.keySerializer = keySerializer;
}
+ @SuppressWarnings({"removal"})
@Override
public Optional<Set<Integer>> partitions(final String topic, final K key,
final V value, final int numPartitions) {
- final byte[] keyBytes = keySerializer.serialize(topic, key);
+ return partitions(topic, key, value, new RecordHeaders(),
numPartitions);
+ }
+
+ @Override
+ public Optional<Set<Integer>> partitions(final String topic, final K key,
final V value, final Headers headers, final int numPartitions) {
+ final byte[] keyBytes = keySerializer.serialize(topic, headers, key);
Review Comment:
Will update KIP. respond in different thread:
https://github.com/apache/kafka/pull/22570/changes#r3597487822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
