AndrewJSchofield commented on code in PR #22780:
URL: https://github.com/apache/kafka/pull/22780#discussion_r3541916668
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -234,9 +246,42 @@ public void onComplete() {
}
}
+ private void completeShareFetchAsyncRequest() {
+ // Check if async read is still not completed then rather waiting
further the request should
+ // be aborted. A warning log should be added to see if the fetches are
taking long.
Review Comment:
nit: The comment about adding a warning log in the future doesn't seem right
here. I would either add the log, or remove the comment.
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -267,20 +311,63 @@ private void completeLocalLogShareFetchRequest() {
}
private void
processAcquiredTopicPartitionsForLocalLogFetch(LinkedHashMap<TopicIdPartition,
Long> topicPartitionData) {
- List<ShareFetchPartitionData> shareFetchPartitionDataList = new
ArrayList<>();
+ // If localPartitionsAlreadyFetched is empty hence the async fetch was
never attempted hence retry
Review Comment:
This doesn't make sense :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
