apoorvmittal10 commented on code in PR #22780:
URL: https://github.com/apache/kafka/pull/22780#discussion_r3546472485
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -2437,13 +2506,28 @@ DelayedShareFetchBuilder withShareFetchData(ShareFetch
shareFetch) {
return this;
}
- DelayedShareFetchBuilder withReplicaManager(ReplicaManager
replicaManager) {
+ DelayedShareFetchBuilder withReplicaManagerLogReader(ReplicaManager
replicaManager) {
this.replicaManager = replicaManager;
this.logReader = new ReplicaManagerLogReader(replicaManager);
this.metadataProvider = new
ReplicaManagerPartitionMetadataProvider(replicaManager);
return this;
}
+ DelayedShareFetchBuilder withReplicaManager(ReplicaManager
replicaManager) {
+ this.replicaManager = replicaManager;
+ return this;
+ }
Review Comment:
Now being used :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
