JiayaoS commented on code in PR #22785:
URL: https://github.com/apache/kafka/pull/22785#discussion_r3542847094
##########
core/src/test/scala/integration/kafka/api/AbstractAuthorizerIntegrationTest.scala:
##########
@@ -100,6 +101,8 @@ class AbstractAuthorizerIntegrationTest extends
BaseRequestTest {
override def brokerPropertyOverrides(properties: Properties): Unit = {
properties.put(ServerConfigs.BROKER_ID_CONFIG, brokerId.toString)
+
properties.put(ShareCoordinatorConfig.STATE_TOPIC_REPLICATION_FACTOR_CONFIG,
"1")
+ properties.put(ShareCoordinatorConfig.STATE_TOPIC_MIN_ISR_CONFIG, "1")
Review Comment:
> We set other replication factor configurations in `addNodeProperties()`,
should we set these there as well?
Good question. I put them in `brokerPropertyOverrides()` because these are
documented as broker configs, so I thought it would be cleaner to keep them
scoped to the broker configs rather than also passing them through
`addNodeProperties()` for the controller configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
