JiayaoS commented on code in PR #22785:
URL: https://github.com/apache/kafka/pull/22785#discussion_r3542896984
##########
core/src/test/scala/integration/kafka/api/AbstractAuthorizerIntegrationTest.scala:
##########
@@ -100,6 +101,8 @@ class AbstractAuthorizerIntegrationTest extends
BaseRequestTest {
override def brokerPropertyOverrides(properties: Properties): Unit = {
properties.put(ServerConfigs.BROKER_ID_CONFIG, brokerId.toString)
+
properties.put(ShareCoordinatorConfig.STATE_TOPIC_REPLICATION_FACTOR_CONFIG,
"1")
+ properties.put(ShareCoordinatorConfig.STATE_TOPIC_MIN_ISR_CONFIG, "1")
Review Comment:
That said, I agree that keeping them with the other replication factor
configs in `addNodeProperties()` would be more consistent with the existing
test setup, so I’m happy to move them there if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
