sjhajharia commented on code in PR #22786:
URL: https://github.com/apache/kafka/pull/22786#discussion_r3549200617
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -907,6 +917,12 @@ def start_node(self, node, timeout_sec=60, **kwargs):
else:
if get_version(node).supports_feature_command():
cmd += " --feature transaction.version=0"
+ if self.share_version is not None:
+ # share.version=2 (KIP-1191 DLQ) declares a bootstrap
metadata.version of 4.4-IV0,
+ # but that isn't yet a valid --release-version for
kafka-storage.sh format in this
+ # build (max supported is 4.3-IV0), and
Feature.validateVersion() does not enforce
+ # the dependency, so the feature can be bootstrapped on its
own.
+ cmd += " --feature share.version=%s" % self.share_version
Review Comment:
Not applicable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
